Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configure-pagefile-action task #725

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

wakingrufus
Copy link
Collaborator

@wakingrufus wakingrufus commented Nov 28, 2023

add display name to plugin metadata to fix broken publish task

@@ -99,8 +99,10 @@ jobs:
- name: set up JDK 1.8
uses: actions/setup-java@v2
with:
java-version: 8
java-version: 11
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well run this on java 11

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure... But then change the title of the step too 🙂😂

distribution: 'zulu'
- name: Install lintian
run: sudo apt install -qq lintian=2.114.0ubuntu1.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkbashisms was resolving its transitive dependency on lintian to a version that no longer exists. i fixed it by explicitly installing a version of the dependency that actually exists

@@ -306,10 +306,12 @@ gradlePlugin {
register("ktlintPlugin") {
id = "org.jlleitschuh.gradle.ktlint"
implementationClass = "org.jlleitschuh.gradle.ktlint.KtlintPlugin"
displayName = "Ktlint Gradle Plugin"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to pass new validation rules (this caused previous release to fail)

@@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v2
- name: configure windows pagefile
if: ${{ matrix.os == 'windows-latest' }}
uses: al-cheb/configure-pagefile-action@v1.2
uses: al-cheb/configure-pagefile-action@v1.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to solve node version warning

@JLLeitschuh
Copy link
Owner

One thing to fix, then happy to merge! 🙂

add display name to plugin metadata to fix broken publish task
Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JLLeitschuh JLLeitschuh merged commit ff8f764 into main Nov 30, 2023
16 of 17 checks passed
@wakingrufus wakingrufus deleted the update-pagefile-task branch November 30, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants