Add support for deprecated attribute and update the presets search dialog #123
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // License: GPL. For details, see LICENSE file. | ||
| package org.openstreetmap.josm.gui.tagging.presets; | ||
|
|
||
| import java.util.EnumMap; | ||
| import java.util.Map; | ||
|
|
||
| import static org.openstreetmap.josm.tools.I18n.marktr; | ||
|
|
||
| /** | ||
| * This enum defines different filters for searching presets. | ||
| */ | ||
|
|
||
| public enum PresetSearchFilter { | ||
| ONLY_APPLICABLE(marktr("Show only applicable to selection")), | ||
| SEARCH_IN_TAGS(marktr("Search in tags")), | ||
| DEPRECATED_TAGS(marktr("Show deprecated tags")); | ||
|
|
||
| /** | ||
| * Map containing the preferences for the filters | ||
| */ | ||
| private Map<PresetSearchFilter, Boolean> filtersPreference; | ||
|
|
||
| static { | ||
| for (PresetSearchFilter filter : values()) { | ||
| filter.filtersPreference = new EnumMap<>(PresetSearchFilter.class); | ||
| filter.filtersPreference.put(filter, true); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Sets the preference for the filter | ||
| * @param filter the filter to set the preference for | ||
| * @param pref true if the filter is enabled, false otherwise | ||
| * @since xxx | ||
| */ | ||
| public void setPref(PresetSearchFilter filter, Boolean pref) { | ||
| filtersPreference.put(filter, pref); | ||
| } | ||
|
|
||
| /** | ||
| * Gets the preference for the filter | ||
| * @param filter the filter to get the preference for | ||
| * @return true if the filter is enabled, false otherwise | ||
| * @since xxx | ||
| */ | ||
| public Boolean getPref(PresetSearchFilter filter) { | ||
| return filtersPreference.get(filter); | ||
|
There was a problem hiding this comment. This should be done via the standard |
||
| } | ||
|
There was a problem hiding this comment. When I said, "we should use an EnumMap", this is not what I was thinking. I'll go find one of the methods using this enum and see if I can hack together something there as an example. Generally speaking, |
||
|
|
||
| /** | ||
| * The translated text associated with the enum constant. | ||
| */ | ||
| private final String translatedText; | ||
|
|
||
| /** | ||
| * Constructor for the PresetSearchFilter enum. | ||
| * Initializes an enum constant with its corresponding translated text. | ||
| * | ||
| * @param translatedText The translated text associated with the enum constant. | ||
| */ | ||
| PresetSearchFilter(String translatedText) { | ||
| this.translatedText = translatedText; | ||
|
There was a problem hiding this comment. To avoid confusion, this should probably be |
||
| } | ||
|
|
||
| /** | ||
| * Returns the text associated with the filter | ||
| * @return the text marked for translation | ||
| */ | ||
| public String getText() { | ||
| return translatedText; | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the equivalent of
new TaggingPresetSelector(true, true, true), which I don't think you wanted. You probably wanted to just donew TaggingPresetSelector().