Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Composition Context to prevent composition overwrite #35

Merged
merged 2 commits into from
May 19, 2017

Conversation

JSkimming
Copy link
Owner

@JSkimming JSkimming commented May 16, 2017

Fixed #14

@JSkimming JSkimming self-assigned this May 16, 2017
@codecov-io
Copy link

codecov-io commented May 16, 2017

Codecov Report

Merging #35 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files          56       56              
  Lines        1491     1516      +25     
  Branches      273      281       +8     
==========================================
+ Hits         1490     1515      +25     
  Misses          1        1
Impacted Files Coverage Δ
...Visitors/FactoryRegistrationVisitor.WithContext.cs 100% <100%> (ø) ⬆️
...ors/TypedFactoryRegistrationVisitor.WithContext.cs 100% <100%> (ø) ⬆️
...n/Visitors/InjectedSingletonRegistrationVisitor.cs 100% <100%> (ø) ⬆️
src/Abioc/Composition/CodeComposition.cs 100% <100%> (ø) ⬆️
...Composition/Compositions/ConstructorComposition.cs 100% <100%> (ø) ⬆️
src/Abioc/Composition/RegistrationComposition.cs 100% <100%> (ø) ⬆️
...mposition/Visitors/SingletonRegistrationVisitor.cs 100% <100%> (ø) ⬆️
...Composition/Visitors/FactoryRegistrationVisitor.cs 100% <100%> (ø) ⬆️
src/Abioc/Composition/CompositionContext.cs 100% <100%> (ø) ⬆️
...n/Visitors/SingleConstructorRegistrationVisitor.cs 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb4298...7572b71. Read the comment docs.

@JSkimming JSkimming merged commit a7d87b4 into master May 19, 2017
@JSkimming JSkimming deleted the composition-refactor branch May 19, 2017 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants