snap: fix for native-messaging-host permissions (#6062)

* snap: fix for native-messaging-host permissions
add hook for chrome/chromium

* snap: fix no newline

* Add snap browser integration to changelog

CHANGELOG.md

@@ -13,6 +13,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 
 ### Changed
 
+- Added browser integration to the snap package for firefox/chromium browsers. [#6062](https://github.com/JabRef/jabref/pull/6062)
 - We reintroduced the possibility to extract references from plain text (using [GROBID](https://grobid.readthedocs.io/en/latest/)). [#5614](https://github.com/JabRef/jabref/pull/5614)
 - We changed the open office panel to show buttons in rows of three instead of going straight down to save space as the button expanded out to take up unnecessary horizontal space. [#5479](https://github.com/JabRef/jabref/issues/5479)
 - We cleaned up the group add/edit dialog. [#5826](https://github.com/JabRef/jabref/pull/5826)

snap/hooks/connect-plug-etc-chromium-native-messaging-jabref

@@ -0,0 +1,9 @@
+#!/bin/sh
+
+if [ ! -d /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts ]; then
+    echo "Missing directory, create it manually then try again:"
+    echo "sudo mkdir -p /etc/chromium/native-messaging-hosts"
+    exit 1
+fi
+
+cp "$SNAP/lib/native-messaging-host/chromium/org.jabref.jabref.json" /etc/chromium/native-messaging-hosts/org.jabref.jabref.json

snap/hooks/connect-plug-etc-opt-chrome-native-messaging-jabref

@@ -0,0 +1,9 @@
+#!/bin/sh
+
+if [ ! -d /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts ]; then
+    echo "Missing directory, create it manually then try again:"
+    echo "sudo mkdir -p /etc/opt/chrome/native-messaging-hosts"
+    exit 1
+fi
+
+cp "$SNAP/lib/native-messaging-host/chromium/org.jabref.jabref.json" /etc/opt/chrome/native-messaging-hosts/org.jabref.jabref.json

snap/hooks/connect-plug-browser-extension → snap/hooks/connect-plug-hostfs-mozilla-native-messaging-jabref

@@ -6,4 +6,4 @@ if [ ! -d /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts ]; then
     exit 1
 fi
 
-cp $SNAP/lib/org.jabref.jabref.json /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json
+cp "$SNAP/lib/native-messaging-host/firefox/org.jabref.jabref.json" /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json

snap/hooks/disconnect-plug-etc-chromium-native-messaging-jabref

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+if [ ! -f /etc/chromium/native-messaging-hosts/org.jabref.jabref.json ]; then
+    exit 0
+elif grep --quiet '"path": "/snap' /etc/chromium/native-messaging-hosts/org.jabref.jabref.json; then
+    rm /etc/chromium/native-messaging-hosts/org.jabref.jabref.json
+fi

snap/hooks/disconnect-plug-etc-opt-chrome-native-messaging-jabref

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+if [ ! -f /etc/opt/chrome/native-messaging-hosts/org.jabref.jabref.json ]; then
+    exit 0
+elif grep --quiet '"path": "/snap' /etc/opt/chrome/native-messaging-hosts/org.jabref.jabref.json; then
+    rm /etc/opt/chrome/native-messaging-hosts/org.jabref.jabref.json
+fi

snap/hooks/disconnect-plug-browser-extension → snap/hooks/disconnect-plug-hostfs-mozilla-native-messaging-jabref

@@ -4,4 +4,4 @@ if [ ! -f /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabre
     exit 0
 elif grep --quiet '"path": "/snap' /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json; then
     rm /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json
-fi
+fi

snap/snapcraft.yaml

@@ -12,6 +12,28 @@ license: MIT
 architectures:
   - build-on: amd64
 
+plugs:
+  desktop:
+  desktop-legacy:
+  wayland:
+  unity7:
+  home:
+  opengl:
+  network-bind:
+  removable-media:
+  hostfs-mozilla-native-messaging-jabref:
+    interface: system-files
+    write:
+    - /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json
+  etc-opt-chrome-native-messaging-jabref:
+    interface: system-files
+    write:
+    - /etc/opt/chrome/native-messaging-hosts/org.jabref.jabref.json
+  etc-chromium-native-messaging-jabref:
+    interface: system-files
+    write:
+    - /etc/chromium/native-messaging-hosts/org.jabref.jabref.json
+
 apps:
   jabref:
     command: bin/JabRef
@@ -22,34 +44,13 @@ apps:
 
 environment:
   _JAVA_OPTIONS: "-Duser.home=$SNAP_USER_DATA"
-plugs:
-  desktop:
-  desktop-legacy:
-  wayland:
-  unity7:
-  home:
-  opengl:
-  network-bind:
-  removable-media:
-  plugs:
-    hostfs-mozilla-native-messaging-jabref:
-      interface: system-files
-      write:
-      - /var/lib/snapd/hostfs/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json
-    hostfs-chrome-native-messaging-jabref:
-      interface: system-files
-      write:
-      - /var/lib/snapd/hostfs/etc/opt/chrome/native-messaging-hosts/org.jabref.jabref.json
-    hostfs-chromium-native-messaging-jabref:
-      interface: system-files
-      write:
-      - /var/lib/snapd/hostfs/etc/chromium/native-messaging-hosts/org.jabref.jabref.json
+
 parts:
   jabref:
     plugin: dump
-    source: build/distribution/JabRef-portable_linux.tar.gz
+    # source: build/distribution/JabRef-5.0-portable_linux.tar.gz
     # Use this source for debug purposes:
-    # source: https://builds.jabref.org/master/JabRef-portable_linux.tar.gz
+    source: https://builds.jabref.org/master/JabRef-5.0-portable_linux.tar.gz
     stage-packages:
       - x11-utils
     override-build: |