Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries can only have one group color/color information is lost when JabRef is closed #4574

Closed
1 task done
douglasrizzo opened this issue Jan 9, 2019 · 8 comments
Closed
1 task done
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups maintable type: enhancement

Comments

@douglasrizzo
Copy link

JabRef version 5.0

Hello there, I am trying version 5.0 of JabRef on Manjaro Linux. I don't know how previous versions behave regarding what I am about to describe. Suppose I have a group, whose color I set to red and a subgroup, whose color I set to blue. It so happens that, when I select the subgroup, all entries are colored red and none of them are blue.

2019-01-09-194635_682x746_scrot

The behavior I expected was for entries in the subgroup to have two color bars, one red and one blue, so I am able to know all colored groups this entry is a part of.

If I save my database, close and reopen JabRef, the color for the subgroup is unset (erased from the bib file) and only the color for the supergroup remains.

2019-01-09-194719_682x746_scrot

When trying to erase a group's color information myself, I realized there's no way to do that using the GUI. Once you set a color for a group, there's no way to erase it. Even setting the value that is in the color box by default (#FFFFFF) just paints all entries white instead of leaving them colorless. I had to delete the color value from my bib file to fix this.

For my next test, I set two different colors for two groups which have a few entries in common. First, I set one group as purple. You can see in the image below that there is a second group which has some entries that are purple.

2019-01-09-195018_682x746_scrot

I then set the entries of this subgroup to green. All entries that were previously colorless were colored green, while the ones that were already purple remained purple.

2019-01-09-195041_682x746_scrot

In the purple group, which had some entries from the green group, no entries were colored green. Again, after I saved, closed and reopened JabRef, the color information from both groups was lost.

Since I observed that the purple color (which I had set first) had precedence over green, I tried to do the opposite and set the color of the green group first and then set the color for the purple group, but purple still took precedence. I believe this is because the purple group is listed first in my database and in my bib file.

From these tests, it seems to me in that entries can only have a single color. JabRef has some way of prioritizing which color to assign to an entry (supergroups first or maybe simply groups that are listed first in the groups list) and, in case the colors from two groups overlap, JabRef deletes the information regarding the color from one or both groups. At runtime, it also has some way of prioritizing which color to display, as in my second test, purple was displayed on top of green.

I believe that, if an entry is able to be represented by multiple colors, all these problems would go away.

Thanks for taking the time to read this.

@tobiasdiez
Copy link
Member

So the TLDR is:

  • Enhancement: show the color of all groups that an entry belongs to
  • Bug: color information for subgroups is deleted
  • Enhancement: add possibility to erase color in group edit dialog

Concerning the first point, I'm not sure what's the best way to show the color of all groups in the main table. Simply adding a colored bar for each group might work for two or three group memberships but runs into problems for more groups (just imagine 10 colored bars...). Another possibility is to segment the one bar currently shown and color each segment accordingly.

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs type: enhancement groups maintable labels Jan 9, 2019
@douglasrizzo
Copy link
Author

I think the colored bar is small enough that more bars can be added without much problem. Segmenting a single bar into 10 colors could create a visibility problem though.

Regarding the bug, it seems to happen only when two groups share some common entries.

@AEgit
Copy link

AEgit commented Apr 8, 2019

@douglasrizzo : "I think the colored bar is small enough that more bars can be added without much problem."

I disagree with this statement (@tobiasdiez already mentioned the issue): I have thousands of groups and there should be entries that are assigned to 10 groups or more. Just adding additional bars for each group would become problematic. I agree, that segmenting a single bar into 10 colours might create a visibility problem.
Potential solution (not the best, but maybe something): Have a (user-defined?) cut-off value for bars/colours displayed. If there are more colours/bars to be shown than given by the cut-off value, they will not be displayed (or only some of them will) and one bar will be added which indicates that the cut-off threshold has been exceeded.

@douglasrizzo
Copy link
Author

Color bars can be displayed according to the width of the column that is used to display them.

@AEgit
Copy link

AEgit commented Apr 11, 2019

Yes, that would work - as long as it is clear, that some bars are not shown (due to the limited width of the column used to display them).

@JoElfner
Copy link

Any news on this? I just ran into this and it feels like a nice addition for large libraries...

tobiasdiez added a commit that referenced this issue Sep 26, 2019
Shows multiple colored bars if the entry belongs to more than one group (with color). Implements #4574.
@matthiasgeiger
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master.

@AEgit
Copy link

AEgit commented Oct 31, 2019

JabRef 5.0.0-dev--2019-10-28----075f191dd
Windows 10 10.0 amd64
Java 12.0.2

As far as I can tell, this issue has been fixed in the most recent dev version.

github-actions bot pushed a commit that referenced this issue Feb 26, 2020
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (#4580)
31bacc1 JCL: Fix formatting & space before locator
adfc9b0 Add The Journal of Comparative Law (#4576)
599d39c Create uni-freiburg-geschichte.csl (#4561)
3ad8d40 Add Begell House styles (#4575)
223527b Create begell-apa.csl (#4574)
d73b9a9 Update journal-of-neolithic-archaeology.csl (#4572)
5b2810c Create anatomical-sciences-education.csl (#4573)
9454897 Update ASA style
b3c6efd Reorder/reindent (#4571)
aa52aaa Encrypt Travis CI notification email addresses (#4570)
d8f2843 Update ayer.csl (#4569)
448e67e Create ayer.csl (#4565)
bf1ddae Update springer-basic-author-date.csl (#4562)
db525ac Update american-journal-of-physical-anthropology.csl (#4567)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: f03dece
github-actions bot pushed a commit to systemoperator/jabref that referenced this issue Feb 26, 2020
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#4580)
31bacc1 JCL: Fix formatting & space before locator
adfc9b0 Add The Journal of Comparative Law (JabRef#4576)
599d39c Create uni-freiburg-geschichte.csl (JabRef#4561)
3ad8d40 Add Begell House styles (JabRef#4575)
223527b Create begell-apa.csl (JabRef#4574)
d73b9a9 Update journal-of-neolithic-archaeology.csl (JabRef#4572)
5b2810c Create anatomical-sciences-education.csl (JabRef#4573)
9454897 Update ASA style
b3c6efd Reorder/reindent (JabRef#4571)
aa52aaa Encrypt Travis CI notification email addresses (JabRef#4570)
d8f2843 Update ayer.csl (JabRef#4569)
448e67e Create ayer.csl (JabRef#4565)
bf1ddae Update springer-basic-author-date.csl (JabRef#4562)
db525ac Update american-journal-of-physical-anthropology.csl (JabRef#4567)
9e81857 Update marine-ornithology.csl (JabRef#4566)
938537e Update government-and-opposition.csl (JabRef#4564)
50d0635 Update annales-de-demographie-historique.csl (JabRef#4560)
42b54d9 Create marine-ornithology.csl (JabRef#4559)
eff41bb Create dermatology-online.csl (JabRef#4558)
3911696 Update journal-of-forensic-sciences.csl (JabRef#4554)
059ea33 Small capitals and categories (JabRef#4556)
97b8c84 Create CSL Styles: estudios_hispanicos.csl (JabRef#4557)
57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4552)
f481ea3 Create ipb-ppki-3.csl (JabRef#4550)
899d302 Update journal-of-neolithic-archaeology.csl (JabRef#4553)
e106215 Create annales-de-demographie-historique.csl (JabRef#4512)
4dd974e Create lauterbornia.csl (JabRef#4525)
e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551)
f9cfe40 Add new IOP dependents (JabRef#4549)
daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544)
10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: f03dece
github-actions bot pushed a commit to calixtus/jabref that referenced this issue Feb 27, 2020
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#4580)
31bacc1 JCL: Fix formatting & space before locator
adfc9b0 Add The Journal of Comparative Law (JabRef#4576)
599d39c Create uni-freiburg-geschichte.csl (JabRef#4561)
3ad8d40 Add Begell House styles (JabRef#4575)
223527b Create begell-apa.csl (JabRef#4574)
d73b9a9 Update journal-of-neolithic-archaeology.csl (JabRef#4572)
5b2810c Create anatomical-sciences-education.csl (JabRef#4573)
9454897 Update ASA style
b3c6efd Reorder/reindent (JabRef#4571)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: f03dece
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this issue Mar 1, 2020
566df87 Create archeologicke-rozhledy.csl (JabRef#4586)
4205586 Update mcgill-en.csl - include render-legislation macro (JabRef#4579)
7d857f1 Create journal-of-plankton-research.csl (JabRef#4581)
05c8aca Update mercator-institut-fur-sprachforderung-und-deutsch-als-zweitsprache.csl (JabRef#4582)
564dc5f Update vodohospodarske-technicko-ekonomicke-informace.csl (JabRef#4584)
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#4580)
31bacc1 JCL: Fix formatting & space before locator
adfc9b0 Add The Journal of Comparative Law (JabRef#4576)
599d39c Create uni-freiburg-geschichte.csl (JabRef#4561)
3ad8d40 Add Begell House styles (JabRef#4575)
223527b Create begell-apa.csl (JabRef#4574)
d73b9a9 Update journal-of-neolithic-archaeology.csl (JabRef#4572)
5b2810c Create anatomical-sciences-education.csl (JabRef#4573)
9454897 Update ASA style
b3c6efd Reorder/reindent (JabRef#4571)
aa52aaa Encrypt Travis CI notification email addresses (JabRef#4570)
d8f2843 Update ayer.csl (JabRef#4569)
448e67e Create ayer.csl (JabRef#4565)
bf1ddae Update springer-basic-author-date.csl (JabRef#4562)
db525ac Update american-journal-of-physical-anthropology.csl (JabRef#4567)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 566df87
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this issue Mar 1, 2020
566df87 Create archeologicke-rozhledy.csl (JabRef#4586)
4205586 Update mcgill-en.csl - include render-legislation macro (JabRef#4579)
7d857f1 Create journal-of-plankton-research.csl (JabRef#4581)
05c8aca Update mercator-institut-fur-sprachforderung-und-deutsch-als-zweitsprache.csl (JabRef#4582)
564dc5f Update vodohospodarske-technicko-ekonomicke-informace.csl (JabRef#4584)
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#4580)
31bacc1 JCL: Fix formatting & space before locator
adfc9b0 Add The Journal of Comparative Law (JabRef#4576)
599d39c Create uni-freiburg-geschichte.csl (JabRef#4561)
3ad8d40 Add Begell House styles (JabRef#4575)
223527b Create begell-apa.csl (JabRef#4574)
d73b9a9 Update journal-of-neolithic-archaeology.csl (JabRef#4572)
5b2810c Create anatomical-sciences-education.csl (JabRef#4573)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 566df87
github-actions bot pushed a commit to abepolk/jabref that referenced this issue Mar 1, 2020
566df87 Create archeologicke-rozhledy.csl (JabRef#4586)
4205586 Update mcgill-en.csl - include render-legislation macro (JabRef#4579)
7d857f1 Create journal-of-plankton-research.csl (JabRef#4581)
05c8aca Update mercator-institut-fur-sprachforderung-und-deutsch-als-zweitsprache.csl (JabRef#4582)
564dc5f Update vodohospodarske-technicko-ekonomicke-informace.csl (JabRef#4584)
f03dece Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#4580)
31bacc1 JCL: Fix formatting & space before locator
adfc9b0 Add The Journal of Comparative Law (JabRef#4576)
599d39c Create uni-freiburg-geschichte.csl (JabRef#4561)
3ad8d40 Add Begell House styles (JabRef#4575)
223527b Create begell-apa.csl (JabRef#4574)
d73b9a9 Update journal-of-neolithic-archaeology.csl (JabRef#4572)
5b2810c Create anatomical-sciences-education.csl (JabRef#4573)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 566df87
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups maintable type: enhancement
Projects
Archived in project
Development

No branches or pull requests

5 participants