Name behaviour when generating a bibtexkey

[wujastyk]

JabRef 5.0.0-dev--2019-10-31----ac7875a96
Linux 5.0.0-32-generic amd64
Java 12.0.2

JabRef version on

• [ X] I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behaviour:

1. Fill out Author and date.
2. Author in the form "Surname, Firstname."
3. Preferences set the default key pattern to "[auth4:lower]-[year]"
4. Hit "generate key"
5. The result is firs-2018.
6. It used to be - correctly - "surn-2018"

[Siedlerchr]

Could you please add the entry here so that we can better check it?

[wujastyk]

A MWE:

@Article{john-2019,
author = {Smith, John},
date = {2019},
}

[Siedlerchr]

Okay, I can get the same behavior . For reference the help says:
[authN]: The first N characters of the first author’s last name

Seems like the author parser doesn't parse it correctly

[Ka0o0]

Hi,
I would like to tackle this bug.
I found that in BracketedPattern.java on line 846 the comma is removed and therefore the AuthorList is not correct.
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java#L846

I would fix this issue by not applying BibtexKeyGenerator.removeUnwantedCharacters before extracting the author but afterwards. The tests pass, but can anyone think of a problem with that approach?

[tobiasdiez]

Thanks to @Ka0o0 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

[Siedlerchr]

Please note that the binary for windows is currently not beeing updated due to a bug in the release system. Linux and Mac are not affected.