Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a duplicate reference entry via JabRef-Browser-Extensions and using the merge feature is erroneous #5858

Closed
systemoperator opened this issue Jan 21, 2020 · 5 comments

Comments

@systemoperator
Copy link
Contributor

systemoperator commented Jan 21, 2020

I am using the latest JabRef 5 master build:
on Ubuntu 16.04

Steps to reproduce it:

  1. Import reference R into JabRef using the official JabRef-Browser-Extension.
  2. (Accidentally) delete some data/letters and/or add additional information to the imported reference R in JabRef (and optionally save updated library).
  3. Trigger re-importing the same reference R to JabRef using the JabRef-Browser-Extension once again.
  4. In JabRef's import dialog a small indicator appears, when hovering, it states "Possible duplicate of existing entry. Click to resolve."
  5. Click the resolve button.
  6. In the merge dialog select all those values of the reference R from the fresh import (labelled with "From import"), which have been (accidentally) deleted/modified previously.
  7. Press the button "Keep merged entry only" at the merge dialogue.
  8. The merge dialog vanishes.
  9. Now, whatever I do with the still visible import dialogue (either pressing "Cancel" or "Import entries" to import the selected reference R once again), the previous merge process finalized in step 7. has no effect. ADD: Ok, now I see what is going on: The previously merged result is now "stored" in the entry which is shown in the import dialog. If this entry gets imported now and one clicks at the subsequent alert message "Duplicates found" the button "Continue with import", then the old (modified) entry and the freshly merged entry appear side by side in the reference list. In the merge process in step 7. I would have expected, that the already imported, old entry gets updated and no new reference gets imported due to the previous merge process, since the merge button is labelled with "Keep merged entry only".

Furthermore, in step 7. with the merge dialogue:

  • If the button "Remove old entry" gets clicked instead of the button "Keep merged entry only", the old entry will still not be removed and nothing happens.
  • I am not sure, whether the button "Keep both" is needed in the merge dialogue (or whether it has any effect), since it seems equivalent to "Cancel".
  • The button "Remove old entry" is NOT operational.
  • The button "Remove entry from import" is operational.
@systemoperator systemoperator changed the title Importing a duplicate reference entry via JabFox and using the merge feature is erroneous Importing a duplicate reference entry via JabRef-Browser-Extensions and using the merge feature is erroneous Dec 19, 2020
@systemoperator
Copy link
Contributor Author

Issues still persists. Description has been extended.

@ruilvo
Copy link

ruilvo commented Aug 13, 2021

I have this exact issue, as filed. Commenting to try re-opening it.

@Siedlerchr Siedlerchr reopened this Aug 13, 2021
@ruilvo
Copy link

ruilvo commented Aug 13, 2021

For completeness:

JabRef 5.3--2021-07-05--50c96a2
Windows 10 10.0 amd64 
Java 16.0.1 
JavaFX 16+8

My problem is exactly what the OP describes. I use the web extension a lot because it gathers more stuff than DoI. It's often that I add something via DoI or file, and then visit the webpage to get the extra information, and get it merged. But right now, I end up having to import, accept the merge error, and then manually merging.

As the OP mentioned, the little button in the corner in the import window does nothing as far as I'm concerned. I try to "keep merge" but nothing happens....

I think this showcases the issue:

2021-08-13.11-55-24.mp4

koppor pushed a commit that referenced this issue Feb 1, 2022
76f23a2 Fix the order for conference papers in APA styles (#5875)
5125c43 Fix bibliography date sorting (#5876)
873df06 Change order of publisher and publisher-place (#5874)
8066c66 Fix independent for BioScientific Review
9cc567e Add AMA brackets w 2 dependents (#5871)
c33dd24 Create medicine-publishing.csl (#5866)
9cb9cdb Fishery&wildlife journals: Remove publishers for articles (#5868)
fbd9165 Update universitatsmedizin-gottingen.csl (#5864)
c563f03 Update mla8 and mla9 (#5859)
98d6a03 [ASM] Add DOI for preprints. (#5862)
05e7071 Create current-neurology-aktualnosci-neurologiczne.csl (#5858)
78d771d Update journal-of-clinical-neurophysiology.csl (#5857)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 76f23a2
@HoussemNasri
Copy link
Member

Refs #6190

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
@JabRef JabRef deleted a comment from github-actions bot Feb 22, 2024
@JabRef JabRef deleted a comment from github-actions bot Feb 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
#10914)

* Fix duplicate check/merge entries dialog not triggered on import from browser


Refs #5858

* changelog

* remove double duplicate check

* remove l10n

* add icon, downloading is also handled in import entries

* changelog

* fix l10n

* Update JabRef_en.properties

* Update ImportEntriesDialog.java

---------

Co-authored-by: Oliver Kopp <[email protected]>
@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
* issue #10661 - feat: added option to export in cff

* issue #10661 - feat: updated CHANGELOG.md

* issue #10661 - feat: added date field to cff export

* issue #10661 - fix: fixed checkstyle errors

* Bump org.apache.lucene:lucene-queries from 9.9.1 to 9.10.0 (#10920)

* Bump org.apache.lucene:lucene-queries from 9.9.1 to 9.10.0

Bumps org.apache.lucene:lucene-queries from 9.9.1 to 9.10.0.

---
updated-dependencies:
- dependency-name: org.apache.lucene:lucene-queries
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* introduce var for lucene

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siedlerchr <[email protected]>

* Fix for delete entries should ask user (#10591)

* Implemented the feature that deleting files which linked to selected entries when user select deletion, and keeping files unchanged when user select cut

* The following features are implemented: 1.Initializes a pop-up dialog box to confirm whether the user wants to delete attached files from selected entry. 2.Keep track of user preference: if the user prefers always delete attached files, delete the files without displaying the dialog box. 3. Add preference options in File>Preference>Linked Files>Attached files so that users can manage preferences

* update CHANGELOG.md

* Add language keys to english language file

* restore files in src/main/resources/csl-locales and src/main/resources/csl-styles

* Removed unnecessary comments and finxed some requested changes. Added new features: 1. When deleting attached files, the name of files to be deleted will be displayed. 2. Solved the access error caused by repeated deletion of files when one file is attached to multiple entries.

* Add language keys to english language file

* Modify language keys to english language file

* made deleteFileFromDisk method static

* update comment of method deleteFileFromDisk

* fixed coding styles

* restored unexpected code changes

* fix logic

* try null

* todo

* Unify dialogs that confirmation deleting files

* Get around LinkedFile in LIbraryTab, Encapsulate LinkedFile into LinkedFileViewModel

* fix style

* restore files

* Unified the different dialogs when deleting entries, removerd unnecessary dialogs

* fix csl-styles

* try to fix csl-styles

* try to fix csl-styles again

* try to fix csl-styles again 2

* try to fix csl-styles again 3

* Update prompts in en.properties

* New features

- Add to Trash
- Group file-related language strings together

* Fix architecture tests

* Introduce list of files to delete

* Streamline 1 vs. many files

* Fix openRewrite

* Discard changes to src/test/resources/org/jabref/logic/search/test-library-with-attached-files.bib

* Adapt true/false logic according to expectations

* Add "Trash" to CHANGELOG.md

* Fix localization

* Fix JabRef_en.properties

* Add some debug statements

* Fix preferences

* Separate log entries by empty line

* More refined dialog

---------

Co-authored-by: Siedlerchr <[email protected]>
Co-authored-by: Oliver Kopp <[email protected]>
Co-authored-by: Carl Christian Snethlage <[email protected]>

* Fix variable name

* Fix duplicate check/merge entries dialog not triggered on import from… (#10914)

* Fix duplicate check/merge entries dialog not triggered on import from browser


Refs #5858

* changelog

* remove double duplicate check

* remove l10n

* add icon, downloading is also handled in import entries

* changelog

* fix l10n

* Update JabRef_en.properties

* Update ImportEntriesDialog.java

---------

Co-authored-by: Oliver Kopp <[email protected]>

* issue #10661 - fix: fixed PR review comments

Made a class comment in CffDate.java
Replaced System.lineseparator() with OS.NEWLINE in CffDate.java
Added a final newline in cff.layout file

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siedlerchr <[email protected]>
Co-authored-by: shawn-jj <[email protected]>
Co-authored-by: Oliver Kopp <[email protected]>
Co-authored-by: Carl Christian Snethlage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants