-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: re-implemented bib entry highlight when dragging and dropping files #11973
base: main
Are you sure you want to change the base?
Conversation
I am not sure that removing all the colors is really a good idea, they were implemented for the different searching options ("floating mode") with groups and without groups |
Yes, this would remove the visual distinction between matching groups in floating search mode. |
Ah that makes sense! I thought for some reason the deleted section was redundant, I'll rework it to work around the matching groups in floating search mode. Thanks for the feedback! |
What is the status here? |
Link to PRs "fixing" the colors: #11591 |
I think you mentioned the wrong |
Ooops, sorry. 🤣 |
Closes #11898
Removed a chunk of code that was overriding the background colour of bib entires when dragging and dropping a file. Initially caused by changes implemented when resolving #11579.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)