Open "near-by" .bib file #12172
Open "near-by" .bib file #12172
Conversation
CHANGELOG.md
Outdated
| @@ -41,6 +41,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
| - We added an importer for SSRN URLs. [#12021](https://github.com/JabRef/jabref/pull/12021) | |||
| - We added a compare button to the duplicates in the citation relations tab to open the "Possible duplicate entries" window. [#11192](https://github.com/JabRef/jabref/issues/11192) | |||
| - We added automatic browser extension install on Windows for Chrome and Edge. [#6076](https://github.com/JabRef/jabref/issues/6076) | |||
| - We added support to automatically load a `.bib` file in the current/parent folder if no other library is opened. [koppor#377](https://github.com/koppor/jabref/issues/377) | |||
There was a problem hiding this comment.
I did the other way round 😅
|
|
||
| while (currentDir != null) { | ||
| try { | ||
| Optional<Path> bibFile = Files.list(currentDir) |
There was a problem hiding this comment.
this looks horrible. Did you use chatgpt? Better use Files.find that does all this under the hood already
https://mkyong.com/java/java-files-find-examples/
There was a problem hiding this comment.
Also climbing up!!!
I search x/y/z. If there not found, go one dir up.
I can also do recursion...
I do NOT want list all files form root (e.g.., / or c:) and then filter. This takes too long!!
There was a problem hiding this comment.
I search x/y/z. If there not found, go one dir up.
This does not make sense.
I assume a scenario with JabRef portable. You have the bib file next to JabRef.exe and it will load it. This is fine.
But not randomly searching folders up and up or down
And additionally, this features makes so sense under Mac as you have the Appplications folder and all .app apps.
You would never place a file there.
|
This feature need testing with jpackaged app. If it even works there |
Tested. Works fine. Therefore, I crossed
|
Co-authored-by: Ruslan <[email protected]>
Co-authored-by: Ruslan <[email protected]>
Co-authored-by: Ruslan <[email protected]>
We also tested on Linux in the DevCall - and needed to have modifications 😅. |
|
Linux Mint - works! |
koppor
added
the
status: ready-for-review
|
Test failing bc |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Fixes koppor#377.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)