Prevent the search to get focus when deleting/pasting an entry #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now it works for cutting entries too. |
Siedlerchr
requested changes
Oct 29, 2016
| @@ -783,7 +785,10 @@ private void delete() { | |||
| getUndoManager().addEdit(compound); | |||
|
|
|||
| markBaseChanged(); | |||
| frame.output(formatOutputMessage(Localization.lang("Deleted"), entries.size())); | |||
| frame.output(formatOutputMessage(!cut ? Localization.lang("Deleted") : Localization.lang("Cut"), entries.size())); | |||
|
|
|||
There was a problem hiding this comment.
Either you change the condition and put cut instead of not cut or you wrap it in if and else
There was a problem hiding this comment.
I changed it to cut (but didn't change the semantic').
| @@ -183,11 +183,10 @@ public void editSignalled() { | |||
|
|
|||
| public void editSignalled(BibEntry entry) { | |||
| final BasePanelMode mode = panel.getMode(); | |||
| EntryEditor editor = panel.getEntryEditor(entry); | |||
There was a problem hiding this comment.
The new editor was only needed if the condition was met, and previously the focus was possibly set to the wrong editor (if the condition wasn't met).
|
To me code looks good :+2: |
tobiasdiez
approved these changes
Oct 30, 2016
This was referenced Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2208
When you delete an entry the focus will no longer jump to the searchbar, instead it will select the next entry (also counts for pasting).