Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from ESLint to Biome #52

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Migrate from ESLint to Biome #52

wants to merge 20 commits into from

Conversation

bdotsamir
Copy link
Collaborator

Frankly, eslint has left a bad taste in my mouth for quite some time now. Every time I've set it up, it's been a pain to get working, and their latest change with the flatfile introduces some really rough and unintuitive expressions related to the ignores keyword: eslint/eslint#17400

If this is the direction eslint is going, I don't want to use it anymore. Especially when there are suitable alternatives around.

This change is open for discussion before merging. Some key points:

  1. Biome is supposedly faster. Not sure how much that matters for a linter + formatter, but whatever
  2. Biome is relatively new compared to eslint, which has been around since the dinosaurs. As such, the biome ecosystem is not built-up yet. Namely, there's an eslint plugin that verifies SolidJS code (https://github.com/solidjs-community/eslint-plugin-solid). I would have loved to use it, however it appears that the new eslint flatfile format confuses it. I still have yet to try the solid plugin with the old format since it seems to be the most compatible with the older format, however typescript-eslint seems to have already moved to the new flatfile format, stating that the previous format is deprecated.

Also this PR includes a change from the main branch that I forgot to push before creating this branch. Whoops.

@bdotsamir
Copy link
Collaborator Author

I almost forgot to mention: Biome is working on a solid plugin, and I'm subscribed to the issue: biomejs/biome#2438

@JackDotJS
Copy link
Owner

definitely interested in this, eslint is kinda annoying for me to use too.
i also like this part:

Biome is designed from the start to be used interactively within an editor

that said, i wonder if we should wait until the solidjs rules are implemented

@bdotsamir
Copy link
Collaborator Author

rebased

@bdotsamir bdotsamir added the devDependencies Things that make our lives as developers easier label Apr 16, 2024
@JackDotJS
Copy link
Owner

rebased

and mergepilled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devDependencies Things that make our lives as developers easier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants