Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyOpenSci Review #153

Closed
wants to merge 13 commits into from
Closed

PyOpenSci Review #153

wants to merge 13 commits into from

Conversation

JacksonBurns
Copy link
Owner

Responding to comments from review at PyOpenSci - see commit messages for more detail.

 - clarified in the README that this is only intended for regression (we should add an equivalent for classification, with different default metrics, that would perhaps involve creating a new abstract function that both this function and the new one would call)
 - make more general by allowing users to pass in other metrics, or to include their own
@JacksonBurns
Copy link
Owner Author

Closing this in favor of #154 and #155, which cherry pick these commits into documentation updates and code updates for easier reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants