Speed up initialization #143
Comments
|
Some profiling revealed that a lot of time was being spent on For ~500 activities, this reduces the time of As a note for future optimizations, it seems that processing unnecessary file data is not a significant source of slowdown, as commenting out all file reading and all |
JacobEvelyn
added a commit
that referenced
this issue
Jun 5, 2016
This commit simplifies and removes redundant and unnecessary code from `introvert.rb`. Some methods have been removed entirely, and others have been changed so they're used more simply (we now call `set_n_activities!` only while reading the file, instead of as-needed, which adds negligible overhead for some commands but simplifies the calling and reduces error). This change also adds an optimization: in deserializing Activities we now call `Time.parse` if possible, removing the need for slower `Chronic.parse` calls when reading the file (`Chronic` uses `Time.parse` under the hood in these cases anyway). This reduced the runtime of `friends list activities` with ~500 activities (and ~200 friends) from ~2.4 seconds down to ~0.7 seconds. (This optimization resolves #143.) Lastly, this commit adds a slight change in behavior: when commands match friend or location names, they now use those classes' regex methods for matching rather than matching any substring (so a `--with John` command will match a "John Deere" as before, but will a `--with oh` will no longer match "John Deere").
JacobEvelyn
added a commit
that referenced
this issue
Jun 5, 2016
This commit simplifies and removes redundant and unnecessary code from `introvert.rb`. Some methods have been removed entirely, and others have been changed so they're used more simply (we now call `set_n_activities!` only while reading the file, instead of as-needed, which adds negligible overhead for some commands but simplifies the calling and reduces error). This change also adds an optimization: in deserializing Activities we now call `Time.parse` if possible, removing the need for slower `Chronic.parse` calls when reading the file (`Chronic` uses `Time.parse` under the hood in these cases anyway). This reduced the runtime of `friends list activities` with ~500 activities (and ~200 friends) from ~2.4 seconds down to ~0.7 seconds. (This optimization resolves #143.) Lastly, this commit adds a slight change in behavior: when commands match friend or location names, they now use those classes' regex methods for matching rather than matching any substring (so a `--with John` command will match a "John Deere" as before, but will a `--with oh` will no longer match "John Deere").
6 tasks
JacobEvelyn
added a commit
that referenced
this issue
Jun 5, 2016
This commit simplifies and removes redundant and unnecessary code from `introvert.rb`. Some methods have been removed entirely, and others have been changed so they're used more simply (we now call `set_n_activities!` only while reading the file, instead of as-needed, which adds negligible overhead for some commands but simplifies the calling and reduces error). This change also adds an optimization: in deserializing Activities we now call `Time.parse` if possible, removing the need for slower `Chronic.parse` calls when reading the file (`Chronic` uses `Time.parse` under the hood in these cases anyway). This reduced the runtime of `friends list activities` with ~500 activities (and ~200 friends) from ~2.4 seconds down to ~0.7 seconds. (This optimization resolves #143.) Lastly, this commit adds a slight change in behavior: when commands match friend or location names, they now use those classes' regex methods for matching rather than matching any substring (so a `--with John` command will match a "John Deere" as before, but will a `--with oh` will no longer match "John Deere").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice if we could make
friendsperform better, as there is a noticeable lag when thefriends.mdfile is large.The text was updated successfully, but these errors were encountered: