Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing in main #238

Closed
JacobEvelyn opened this issue Sep 24, 2019 · 0 comments · Fixed by #239
Closed

Tests are failing in main #238

JacobEvelyn opened this issue Sep 24, 2019 · 0 comments · Fixed by #239
Assignees
Labels

Comments

@JacobEvelyn
Copy link
Owner

This appears to be related to a simplecov issue

@JacobEvelyn JacobEvelyn self-assigned this Sep 24, 2019
JacobEvelyn added a commit that referenced this issue Sep 24, 2019
This should only pass tests once
simplecov-ruby/simplecov#747 is merged and
incorporated into a new SimpleCov release.

Fixes #238
JacobEvelyn added a commit that referenced this issue Oct 3, 2019
This temporarily pins our simplecov dependency to the version
fixed by simplecov-ruby/simplecov#747 to fix
tests.

Fixes #238
JacobEvelyn added a commit that referenced this issue Oct 3, 2019
This temporarily pins our simplecov dependency to the version
fixed by simplecov-ruby/simplecov#747 to fix
tests.

Fixes #238
JacobEvelyn added a commit that referenced this issue Oct 3, 2019
This commit adds a `Gemfile.old` which is used for testing
old Ruby versions in Travis. This file does not include
dependencies such as Rubocop and SimpleCov that are only
used in either local development or our Travis build for
the latest Ruby version.

Included in these changes is pinning the SimpleCov dependency
to the version fixed by
simplecov-ruby/simplecov#747 to fix tests.

[@shen-sat](https://github.com/shen-sat) was instrumental in
discussing these changes and coming up with many parts of
the overall approach. Many thanks!

Fixes #238
@JacobEvelyn JacobEvelyn changed the title Tests are failing in master Tests are failing in main Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant