Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method error occurred when "remove tag" is executed with no arguments #262

Closed
m-t-a-n-a-k-a opened this issue May 25, 2020 · 2 comments · Fixed by #263
Closed

undefined method error occurred when "remove tag" is executed with no arguments #262

m-t-a-n-a-k-a opened this issue May 25, 2020 · 2 comments · Fixed by #263
Labels
bug

Comments

@m-t-a-n-a-k-a
Copy link
Contributor

VERSION
0.51（ruby 2.6.0）

SUMMARY
When "remove tag" is executed with no arguments, the following error messages are output.

$friends remove tag
Error: undefined method `strip' for nil:NilClass

When "remove nickname”, the error messages are as below.

$friends remove nickname
Error: No friend found for ""

I think it would be better to output "Error: No friend found for" message in the case of "remove tag" as well. 👍
@m-t-a-n-a-k-a m-t-a-n-a-k-a mentioned this issue May 25, 2020
Merged
7 tasks
@JacobEvelyn
Copy link
Owner

Great catch! Thank you for finding this (and sorry for the slow response)! ❤️

JacobEvelyn pushed a commit that referenced this issue Jun 3, 2020
@m-t-a-n-a-k-a
Fix convert_to_tag for the case of str is nil (#263)
a1b3cc1 
* Fix convert_to_tag for the case of str is nil

* Changing str ||= to str.to_s.strip and related test

Closes #262
@JacobEvelyn JacobEvelyn added the bug label Jun 3, 2020
@JacobEvelyn
Copy link
Owner

Thanks so much for fixing this, @m-t-a-n-a-k-a! Your fix is now released in version 0.52! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix convert_to_tag for the case of str is nil m-t-a-n-a-k-a/friends
2 participants
@JacobEvelyn @m-t-a-n-a-k-a