Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 RuboCop errors prevent git commit #78

Closed
codyjroberts opened this issue Jan 16, 2016 · 3 comments
Closed

4 RuboCop errors prevent git commit #78

codyjroberts opened this issue Jan 16, 2016 · 3 comments

Comments

@codyjroberts
Copy link
Contributor

Current master has four RuboCop errors that prevent a git commit without skipping. These are not of great importance but I feel the change is beneficial if not for style then at least to prevent confusion while contributing.
codyjroberts added a commit to codyjroberts/friends that referenced this issue Jan 16, 2016
@codyjroberts
fix 3 rubocop errors
43c6fc9 
Changes are purely for style purposes in accordance to rubocop.yml
settings. These four changes now permit a git commit without skipping
via SKIP=RuboCop.

JacobEvelyn#78
@codyjroberts codyjroberts mentioned this issue Jan 16, 2016
Merged
@JacobEvelyn
Copy link
Owner

Thanks for doing this! My Overcommit/Rubocop setup has been a bit broken recently because of sds/overcommit#315, so I've sadly gotten used to skipping validations.

I really appreciate this change though!

codyjroberts added a commit to codyjroberts/friends that referenced this issue Jan 16, 2016
@codyjroberts
fix 3 rubocop errors
e683111 
Changes are purely for style purposes in accordance to rubocop.yml
settings. These four changes now permit a git commit without skipping
via SKIP=RuboCop.

JacobEvelyn#78
@codyjroberts
Copy link
Contributor Author

No problem. I had never used RuboCop or Overcommit before so it was a bit confusing. Apparently it only prevents a commit if one of the files has an error. This is why running RuboCop in the directory produced far more offenses.

codyjroberts added a commit to codyjroberts/friends that referenced this issue Jan 17, 2016
@codyjroberts
Update rubocop to 0.36
f3fad58 
Disable mutable constants until we tackle frozen strings. Add new
TrailingComma style configs. Fix various offenses.

JacobEvelyn#78
codyjroberts added a commit to codyjroberts/friends that referenced this issue Jan 17, 2016
@codyjroberts
Update rubocop to 0.36
ec00d74 
Enable mutable constants and freeze constant strings adding required
frozen strings comment. Add new TrailingComma style configs. Fix various
offenses.

JacobEvelyn#78
@JacobEvelyn
Copy link
Owner

Fixed in #79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JacobEvelyn @codyjroberts