Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct code coverage calculations #164

Merged
merged 1 commit into from
May 29, 2017
Merged

Correct code coverage calculations #164

merged 1 commit into from
May 29, 2017

Conversation

JacobEvelyn
Copy link
Owner

@JacobEvelyn JacobEvelyn commented May 24, 2017

Fixes #163

Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we
merge this change:

  • The code in these changes works correctly.
  • Code has tests as appropriate.
  • Code has been reviewed by @JacobEvelyn.
  • All tests pass on TravisCI.
  • Rubocop reports no issues on TravisCI.
  • The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

@JacobEvelyn JacobEvelyn force-pushed the coverage branch 8 times, most recently from 753648a to d3181a2 Compare May 29, 2017 13:52
@coveralls
Copy link

coveralls commented May 29, 2017

Coverage Status

Changes Unknown when pulling 3013a6a on coverage into ** on master**.

@coveralls
Copy link

coveralls commented May 29, 2017

Coverage Status

Changes Unknown when pulling e681f16 on coverage into ** on master**.

@JacobEvelyn JacobEvelyn merged commit 8910b84 into master May 29, 2017
@JacobEvelyn JacobEvelyn deleted the coverage branch May 29, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants