Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Memoist dependency and bump gem dependencies #170

Merged
merged 1 commit into from
May 30, 2017
Merged

Remove Memoist dependency and bump gem dependencies #170

merged 1 commit into from
May 30, 2017

Conversation

JacobEvelyn
Copy link
Owner

@JacobEvelyn JacobEvelyn commented May 30, 2017 •
edited
Loading

Resolves #167.

Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we
merge this change:

  • The code in these changes works correctly.
  • Code has tests as appropriate.
  • Code has been reviewed by @JacobEvelyn.
  • All tests pass on Travis CI.
  • Rubocop reports no issues on Travis CI.
  • The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

@coveralls
Copy link

coveralls commented May 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 97.192% when pulling 9f337da on dependent into 4d2d5a1 on master.

@JacobEvelyn JacobEvelyn merged commit dd1789b into master May 30, 2017
@JacobEvelyn JacobEvelyn deleted the dependent branch May 30, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacobEvelyn @coveralls