Improve graph command #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobEvelyn
force-pushed
the
graphing-calculator
branch
from
921ecce
to
65eb4ea
Compare
This is a somewhat hefty commit. Changes: - Remove a few erroneous references to the `--after` flag (which was renamed `--since` to be more accurate before the flag was introduced fully). - Fix a bug that was preventing `graph` from showing more than 42 (how funny!) activities in any month. (Resolves #172) - Change the `graph` behavior to display both the filtered and unfiltered activities to better visualize the proportion of activities that are filtered. This makes `graph` always display all months, except when the `--since` and/or `--until` flags are used. (Resolves #171) - Update the README and `friends.md` to have more recent activities by updating their years. - Change the `stdout_only` helper to print STDERR if it is non-empty, for easier test debugging.
JacobEvelyn
force-pushed
the
graphing-calculator
branch
from
65eb4ea
to
a5a50c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat hefty commit. Changes:
--afterflag (which was renamed
--sinceto be more accuratebefore the flag was introduced fully).
graphfrom showingmore than 42 (how funny!) activities in any month.
(Resolves Graph does not display more than 42 activities per month #172)
graphbehavior to display both thefiltered and unfiltered activities to better visualize
the proportion of activities that are filtered. This
makes
graphalways display all months, except whenthe
--sinceand/or--untilflags are used.(Resolves Change graph commands to display filtered graphs within total #171)
friends.mdto have more recentactivities by updating their years.
stdout_onlyhelper to print STDERR ifit is non-empty, for easier test debugging.
Hi there! Thanks so much for submitting a pull request!
Let's just make sure together that all of these boxes are checked before we
merge this change:
README.mdfile is updated as appropriate.Don't worry—this list will get checked off in no time!