Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix friends edit for multi-word EDITORs #252

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

JacobEvelyn
Copy link
Owner

@JacobEvelyn JacobEvelyn commented Apr 2, 2020

Fixes #251


Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we
merge this change:

  • The code in these changes works correctly.
  • Code has tests as appropriate.
  • Code has been reviewed by @JacobEvelyn.
  • All tests pass on Travis CI.
  • Code coverage remains high.
  • Rubocop reports no issues on Travis CI.
  • The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

@JacobEvelyn JacobEvelyn added the bug label Apr 2, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #252 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          23       23           
  Lines         741      741           
=======================================
  Hits          729      729           
  Misses         12       12           
Impacted Files Coverage Δ
lib/friends/commands/edit.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0a15c...6c4a0f3. Read the comment docs.

@JacobEvelyn JacobEvelyn merged commit 1b4e365 into master Apr 2, 2020
@JacobEvelyn JacobEvelyn deleted the multiword-editor branch April 2, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-word editors no longer work with friends edit
1 participant