Add basic nickname support #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to add nicknames to their friends via the `add nickname` and `remove nickname` commands. Friends can have multiple nicknames. Nicknames are detected in activity text and the friend's full name is substituted as with normal partial name substitutions. Only entire nicknames will be matched for multi-word nicknames. There is currently no limit on how many friends may have the same nickname. Resolves #40.
|
Awesome. |
|
This has been released in v0.8. Enjoy, and let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to add nicknames to their
friends via the
add nicknameandremove nicknamecommands. Friends can have multiple nicknames.
Nicknames are detected in activity text and the
friend's full name is substituted as with normal
partial name substitutions. Only entire nicknames
will be matched for multi-word nicknames.
There is currently no limit on how many friends may
have the same nickname.
Resolves #40.