Fix bug in comparing gem versions for update #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, gem version comparisons were done by coercing both values to rational numbers. This breaks when comparing 0.9 to 0.10, for example (the former is the larger number but the lower version), so this commit switches us to use the Semverse gem for this comparison. Resolves #72.
JacobEvelyn
added a commit
that referenced
this pull request
Jan 13, 2016
Fix bug in comparing gem versions for update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, gem version comparisons were
done by coercing both values to rational
numbers. This breaks when comparing 0.9 to
0.10, for example (the former is the larger
number but the lower version), so this commit
switches us to use the Semverse gem for this
comparison.
Resolves #72.