Skip to content

Commit

Permalink
[SPARK-48141][TEST] Update the Oracle docker image version used for t…
Browse files Browse the repository at this point in the history
…est and integration to use Oracle Database 23ai Free

### What changes were proposed in this pull request?
This proposes to update the Docker image used for integration tests and builds to Oracle Database 23ai Free, version 23.4 (previously we used Oracle Database 23c Free, version 23.3)

### Why are the changes needed?
This is to keep the testing infrastructure up-to-date with the latest Oracle Database Free version.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Existing test infrastructure.

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#46399 from LucaCanali/updateOracleImage.

Lead-authored-by: Luca Canali <[email protected]>
Co-authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
2 people authored and JacobZheng0927 committed May 11, 2024
1 parent f3c67ee commit c83cec3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,6 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
SKIP_UNIDOC: true
SKIP_MIMA: true
SKIP_PACKAGING: true
Expand Down
2 changes: 1 addition & 1 deletion connector/docker-integration-tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ the container bootstrapping. To run an individual Docker integration test, use t

Besides the default Docker images, the integration tests can be run with custom Docker images. For example,

ORACLE_DOCKER_IMAGE_NAME=gvenzl/oracle-free:23.3-slim-faststart ./build/sbt -Pdocker-integration-tests "docker-integration-tests/testOnly *OracleIntegrationSuite"
ORACLE_DOCKER_IMAGE_NAME=gvenzl/oracle-free:23.4-slim-faststart ./build/sbt -Pdocker-integration-tests "docker-integration-tests/testOnly *OracleIntegrationSuite"

The following environment variables can be used to specify the custom Docker images for different databases:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import org.apache.spark.util.Utils

class OracleDatabaseOnDocker extends DatabaseOnDocker with Logging {
lazy override val imageName =
sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME", "gvenzl/oracle-free:23.3-slim")
sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME", "gvenzl/oracle-free:23.4-slim")
val oracle_password = "Th1s1sThe0racle#Pass"
override val env = Map(
"ORACLE_PWD" -> oracle_password, // oracle images uses this
Expand Down

0 comments on commit c83cec3

Please sign in to comment.