Added ADSR envelope with velocity sensitivity #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
referencing #1811 |
OmarEmaraDev
requested changes
Mar 13, 2022
|
If these changes work for you, is it too much trouble to ask you to do a build with py3.10? I had no trouble getting this working on linux, but this windows stuff is a nightmare |
|
Never mind about the build, I got it working, something about defaulting to 32bit even when using the x64 developer console, idfk... |
OmarEmaraDev
approved these changes
Mar 14, 2022
|
@fabricatedmath For the future, builds for all platforms for any pull request can be download from its build artifacts page. |
|
Oh wow good to know, thanks! All the stuff I downloaded and installed to build this on windows feels like malware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github won't let me attach a midi file...
But I set the frame rate to 30 fps, attack to 0.1, decay to 0.1, sustain to its default 0.6 and release to 0.1, First note in my file plays for 0.5s, so attack takes 3 frames, decay takes 3 frames and at frame 15, release happens for 3 frames and at frame 18 its back to 0. Seems to work for Single mode and All mode.
Velocity sensitivity seems to be working as well.
Let me know what you think!