Replace ruamel.yaml with PyYAML and Cleanup Imports
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2023 17:48
This commit makes several improvements with the goal of enhancing code maintainability. Several import statements have been reorganized for consistency and improved readability. ruamel.yaml package usage has been replaced with yaml PyYAML parsing. This decision was made due to its wider usage, more frequent updates, and better integration. This change also necessitates updates in requirement.txt and setup.py. Unit and UAT tests have been updated to reflect these changes. Mkdoxy version has been bumped from 1.1.5 to 1.1.6 to indicate these changes.
The library 'ruamel.yaml' was removed from the development dependencies in setup.py. This was done because it's no longer necessary for the current version of the application. The application's functionality should remain unaffected.
JakubAndrysek
approved these changes
Jul 21, 2023
|
Thanks much for your quick work. I agree with all your future requests. If you have time I will be glad to merge your pull request. Have a nice day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70.
ruamel.yamlwithpyyamlsince it comes withMkDocs.isortto sort importsI tested it with my documentation, seems to work exactly the same. However not sure how to run your tests.
May I suggest (for the future):
pyproject.tomlfromsetup.py