Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwsh): render hyperlink for theme name #1075

Merged

Conversation

lnu
Copy link
Contributor

@lnu lnu commented Oct 18, 2021

render hyperlink for theme name and themes location in Get-PoshThemes
bold attribute removed since it's not really working in windows terminal(microsoft/terminal#109)

Prerequisites

  • I have read and understood the CONTRIBUTING guide
  • The commit message follows the conventional commits guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes/features)

Description

hyperlink for theme path and theme loction in Get-PoshThemes.
works with wsl but windows terminal does not allow to open network uri(wip on their side). The link can be copied and opened as is with explorer.

@lnu lnu force-pushed the feat/get_posh_themes_hyperlink branch from f4782ec to d048983 Compare October 18, 2021 10:58
@JanDeDobbeleer
Copy link
Owner

@lnu would you mind pushing an updated branch? 🙏🏻

render hyperlink for theme name and themes location in Get-PoshThemes
bold attribute removed since it's not really working in windows
terminal(microsoft/terminal#109)
@lnu lnu force-pushed the feat/get_posh_themes_hyperlink branch from 53d26e1 to a103482 Compare October 18, 2021 18:33
@lnu
Copy link
Contributor Author

lnu commented Oct 18, 2021

rebased

@JanDeDobbeleer JanDeDobbeleer merged commit 410fb82 into JanDeDobbeleer:main Oct 18, 2021
@lnu lnu deleted the feat/get_posh_themes_hyperlink branch January 26, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants