Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requiresMainQueueSetup method #28

Closed
rayronvictor opened this issue Dec 29, 2017 · 2 comments
Closed

Add requiresMainQueueSetup method #28

rayronvictor opened this issue Dec 29, 2017 · 2 comments
Labels
react-native plugin

Comments

@rayronvictor
Copy link

  • Version: 8.9.3
  • Platform: 17.3.0 Darwin Kernel Version 17.3.0: Thu Nov 9 18:09:22 PST 2017; root:xnu-4570.31.3~1/RELEASE_X86_64 x86_64
  • Subsystem: nodejs-mobile-react-native

Since React-Native 0.49, requiresMainQueueSetup needs to be defined if the module overrides constantsToExport.

Warning:

RCTLog.js:48 Module RNNodeJsMobile requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.
@jaimecbernardo
Copy link
Member

Hi @rayronvictor,
Thank you for the issue.
We were not aware of this and will look into it.

@rayronvictor rayronvictor mentioned this issue Jan 8, 2018
Merged
jaimecbernardo pushed a commit to JaneaSystems/nodejs-mobile-react-native that referenced this issue Jan 8, 2018
@rayronvictor @jaimecbernardo
rn: add requiresMainQueueSetup and update to 0.52
c32ace3 
Adds requiresMainQueueSetup method, as required since react-native
version 0.49, returning NO because constantsToExport isn't used.
Updates the react-native peerDependency to version 0.52 .

PR-URL: #5
Fixes: JaneaSystems/nodejs-mobile#28
Fixes: JaneaSystems/nodejs-mobile#29
Reviewed-By: Jaime Bernardo <[email protected]>
@jaimecbernardo
Copy link
Member

The fix for this issue landed in JaneaSystems/nodejs-mobile-react-native@c32ace3
Thank you for the contribution!

softdevjs7 added a commit to softdevjs7/nodejs-mobile-react-native that referenced this issue Sep 30, 2022
@softdevjs7
rn: add requiresMainQueueSetup and update to 0.52
3dccee3 
Adds requiresMainQueueSetup method, as required since react-native
version 0.49, returning NO because constantsToExport isn't used.
Updates the react-native peerDependency to version 0.52 .

PR-URL: JaneaSystems/nodejs-mobile-react-native#5
Fixes: JaneaSystems/nodejs-mobile#28
Fixes: JaneaSystems/nodejs-mobile#29
Reviewed-By: Jaime Bernardo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react-native plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rayronvictor @jaimecbernardo