Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send vertex label to user log processor for all mutations #3263

Closed
porunov opened this issue Oct 24, 2022 · 1 comment
Closed

Send vertex label to user log processor for all mutations #3263

porunov opened this issue Oct 24, 2022 · 1 comment

Comments

@porunov
Copy link
Member

porunov commented Oct 24, 2022

Right now using LogProcessorFramework there is no way to retrieve mutated vertex label. Because messages don't include vertex label but only vertex id.
This is a blocker for #3155 .
Without sending vertex label id in the mutation message we won't have vertex label information during log processing.
I.e. vertexLabel() method will always return default vertex label for all received vertices (unless this particular vertex was cached on the receiving instance, which usually isn't the case).
Without knowing vertex label of the mutated vertex we won't be able to properly invalidate indices which are bound to specific vertex label. I.e., those indices which use indexOnly(JanusGraphSchemaType schemaType) method.
To be able to invalidate those indices (necessary for #3155) we should provide vertex label information.

Describe the feature:
Provide vertex label information for mutated vertices in log processor.

Describe a specific use case for the feature:
Implementing global db-cache invalidation feature (#3155).

@porunov porunov added this to the Release v1.0.0 milestone Oct 24, 2022
porunov added a commit to porunov/janusgraph that referenced this issue Oct 24, 2022
porunov added a commit to porunov/janusgraph that referenced this issue Oct 24, 2022
porunov added a commit to porunov/janusgraph that referenced this issue Oct 24, 2022
porunov added a commit to porunov/janusgraph that referenced this issue Nov 4, 2022
porunov added a commit to porunov/janusgraph that referenced this issue Nov 7, 2022
@porunov
Copy link
Member Author

porunov commented Nov 7, 2022

The issue is obsolete because we are able to invalidate cached indexes without knowing vertex label as stated here: #3264 (comment)

Thus, closing this issue.

@porunov porunov closed this as completed Nov 7, 2022
@porunov porunov removed this from the Release v1.0.0 milestone Nov 7, 2022
porunov added a commit that referenced this issue Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant