Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-query support to label step #3915

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

porunov
Copy link
Member

@porunov porunov commented Aug 18, 2023

Benchmarks: #3915 (comment)

Fixes #3813


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@porunov porunov added this to the Release v1.0.0 milestone Aug 18, 2023
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Aug 18, 2023
@porunov
Copy link
Member Author

porunov commented Aug 18, 2023

Benchmarks

master branch:

Benchmark                         (fanoutFactor)  Mode  Cnt      Score     Error  Units
CQLMultiQueryBenchmark.getLabels             100  avgt    5    833.018 ±  34.454  ms/op
CQLMultiQueryBenchmark.getLabels             500  avgt    5  21106.121 ± 416.844  ms/op

This PR branch:

Benchmark                         (fanoutFactor)  Mode  Cnt     Score     Error  Units
CQLMultiQueryBenchmark.getLabels             100  avgt    5    70.820 ±   5.405  ms/op
CQLMultiQueryBenchmark.getLabels             500  avgt    5  1725.351 ± 102.009  ms/op

Conclusion:
In this PR we see label step performs about 12 times faster than in the master branch.

@porunov porunov requested a review from a team August 18, 2023 12:59
Copy link
Member

@FlorianHockmann FlorianHockmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only found one nit.

Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@porunov porunov merged commit 2ffc38b into JanusGraph:master Aug 28, 2023
169 of 170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA kind/performance
Projects
Development

Successfully merging this pull request may close these issues.

Add multi-query support to label step
4 participants