Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota changes #28

Merged
merged 10 commits into from
Feb 8, 2024
Merged

Tasmota changes #28

merged 10 commits into from
Feb 8, 2024

Conversation

Jason2866
Copy link
Owner

This change fixes the following bug(s):

I have tested this change with the following hardware & software combinations:

I have run the esptool.py automated integration tests with this change and the above hardware:

Copy link

github-actions bot commented Feb 8, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Tasmota changes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update build_esptool.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update build_esptool.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update build_esptool.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update build_esptool.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "add Linux arm arm64":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 10 commits (simplifying branch history).
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`main_work`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.
Messages
📖 This PR seems to be quite large (total lines of code: 1943), you might consider splitting it into smaller PRs

👋 Hello Jason2866, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against a6018b9

@Jason2866 Jason2866 merged commit 481495b into merge Feb 8, 2024
12 checks passed
@Jason2866 Jason2866 deleted the main_work branch February 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant