Fix broken downloadBill #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonBoy
reviewed
Aug 6, 2018
lib/Payment.js
Outdated
| @@ -460,15 +462,15 @@ class Payment { | |||
| * digest: 'SHA=ec45d7c24492dcd62d92472b0f2816c8d9a2d773', | |||
| * } | |||
| */ | |||
| download(data, requestOptions) { | |||
| download(data, requestOptions, url = this.paymentUrls.DOWNLOAD_FUND_FLOW) { | |||
There was a problem hiding this comment.
default parameter may break in node v4
|
looks like |
|
@lk9100 yes, that also breaks the travis CI in node4, we may need a major version bump, the webpack 4 also drop the v4 support since I switched to webpack4 to bundle the client side js 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.