Merge pull request #140 from JasonEtco/fix-search-all

Don't include `is:all` in issue filter
JasonEtco · Dec 1, 2022 · 638725f · 638725f
2 parents a2b2af1 + 277e9c1
commit 638725f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/action.ts b/src/action.ts
@@ -23,7 +23,6 @@ function logError(tools: Toolkit, template: string, action: 'creating' | 'updati
 export async function createAnIssue (tools: Toolkit) {
   const template = tools.inputs.filename || '.github/ISSUE_TEMPLATE.md'
   const assignees = tools.inputs.assignees
-  const searchExistingType = tools.inputs.search_existing || 'open'
 
   let updateExisting: Boolean | null = null
   if (tools.inputs.update_existing) {
@@ -62,9 +61,16 @@ export async function createAnIssue (tools: Toolkit) {
 
   if (updateExisting !== null) {
     tools.log.info(`Fetching issues with title "${templated.title}"`)
-    const existingIssues = await tools.github.search.issuesAndPullRequests({
-      q: `is:${searchExistingType} is:issue repo:${process.env.GITHUB_REPOSITORY} in:title ${templated.title}`
-    })
+
+    let query = `is:issue repo:${process.env.GITHUB_REPOSITORY} in:title ${templated.title}`
+
+    const searchExistingType = tools.inputs.search_existing || 'open'
+    const allowedStates = ['open', 'closed']
+    if (allowedStates.includes(searchExistingType)) {
+      query += ` is:${searchExistingType}`
+    }
+
+    const existingIssues = await tools.github.search.issuesAndPullRequests({ q: query })
     const existingIssue = existingIssues.data.items.find(issue => issue.title === templated.title)
     if (existingIssue) {
       if (updateExisting === false) {

diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -193,7 +193,7 @@ describe('create-an-issue', () => {
         const q = parsedQuery['q']
         if (typeof(q) === 'string') {
           const args = q.split(' ')
-          return args.includes('is:all') && args.includes('is:issue')
+          return !args.includes('is:all') && args.includes('is:issue')
         } else {
           return false
         }