export blockEvent to utils, update Options-test and Options to reflec…

…t this change
JedWatson · Jan 5, 2018 · 7f2810a · 7f2810a
1 parent 6f52559
commit 7f2810a
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 17 deletions.
diff --git a/src/Option.js b/src/Option.js
@@ -1,19 +1,7 @@
 import classNames from 'classnames';
 import PropTypes from 'prop-types';
 import React from 'react';
-
-const blockEvent = event => {
-	event.preventDefault();
-	event.stopPropagation();
-	if ((event.target.tagName !== 'A') || !('href' in event.target)) {
-		return;
-	}
-	if (event.target.target) {
-		window.open(event.target.href, event.target.target);
-	} else {
-		window.location.href = event.target.href;
-	}
-};
+import { blockEvent } from './utils/blockEvent';
 
 class Option extends React.Component {
 

diff --git a/src/utils/blockEvent.js b/src/utils/blockEvent.js
@@ -0,0 +1,12 @@
+export default event => {
+	event.preventDefault();
+	event.stopPropagation();
+	if ((event.target.tagName !== 'A') || !('href' in event.target)) {
+		return;
+	}
+	if (event.target.target) {
+		window.open(event.target.href, event.target.target);
+	} else {
+		window.location.href = event.target.href;
+	}
+};
diff --git a/test/Option-test.js b/test/Option-test.js
@@ -9,6 +9,8 @@ import unexpected from 'unexpected';
 import unexpectedDom from 'unexpected-dom';
 import unexpectedSinon from 'unexpected-sinon';
 
+import blockEvent from '../src/utils/blockEvent';
+
 import Option from '../src/Option';
 
 helper();
@@ -123,7 +125,7 @@ describe('Option component', () => {
 				stopPropagation,
 			};
 
-			instance.blockEvent(event);
+			blockEvent(event);
 
 			expect(openStub, 'was called once');
 			expect(openStub, 'was called with', event.target.href, event.target.target);
@@ -146,7 +148,7 @@ describe('Option component', () => {
 
 			expect(window.location.href, 'not to equal', event.target.href);
 
-			instance.blockEvent(event);
+			blockEvent(event);
 
 			expect(window.location.href, 'to equal', event.target.href);
 			expect(openStub, 'was not called');
@@ -169,7 +171,7 @@ describe('Option component', () => {
 
 			expect(window.location.href, 'to equal', 'url');
 
-			instance.blockEvent(event);
+			blockEvent(event);
 
 			expect(window.location.href, 'to equal', 'url');
 			expect(openStub, 'was not called');
@@ -191,7 +193,7 @@ describe('Option component', () => {
 
 			expect(window.location.href, 'to equal', 'url');
 
-			instance.blockEvent(event);
+			blockEvent(event);
 
 			expect(window.location.href, 'to equal', 'url');
 			expect(openStub, 'was not called');