Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: async doesn't change value when onInputChange returns a value #2133

Merged
merged 1 commit into from
Nov 16, 2017
Merged

fixed: async doesn't change value when onInputChange returns a value #2133

merged 1 commit into from
Nov 16, 2017

Conversation

tehbi4
Copy link
Contributor

@tehbi4 tehbi4 commented Nov 7, 2017 •
edited
Loading

This PR fixes #1597, fixes #1941, fixes #2069

Function passed through onInputChange prop will be called with initial input value (stripDiacritics will not be applied in case ignoreAccents and toLowerCase will not be applied in case ignoreCase).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.611% when pulling e71b7a9 on tehbi4:master into 6cc59dd on JedWatson:master.

@tehbi4
Copy link
Contributor Author

tehbi4 commented Nov 10, 2017

Hi @JedWatson! Could you review my fix, please? I really need it in my project.

@JedWatson
Copy link
Owner

Thanks @tehbi4, looks good. I'll get this released.

@JedWatson JedWatson merged commit c22abbd into JedWatson:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tehbi4 @coveralls @JedWatson