Fixed reset input value on closed menu in some case #2232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed readme example. Issue #2235
Fixed console error in GitHub users example
Added missing tests for Async.js
Added missing tests for Option.js and refactored Option-test.js.
Fixed all warnings on running tests
Clee/resolve regression
Fixed focused option. Issue #2237
Updated babel-preset-es2015 to babel-preset-env
Minor src files refactor
Minor Select.js refactor
2234 refactor
…arov/react-select into fix/clear-input-value-on-close # Conflicts: # src/Select.js
|
Closed because incorrect merged. |
|
and it was fixed in #2259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input value reset after pressing enter button on closed menu.
How to reproduce?:
Add props to multiselect example:
onSelectResetsInput={false}
onCloseResetsInput={false}
onBlurResetsInput={false}
Type in multiselect 'o' then press enter and one more time press enter. See that input value was reset.
The bug:
The fix: