Add aria attributes to dummy input #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JedWatson is it possible to get this added into the library? Not having the ability to add aria labels to non-searchable inputs makes this library unsuitable for projects required to meet modern accessibility standards. |
|
Can we revisit this fix? It would be great to get this in to solve accessibility issues with this component. |
jossmac
approved these changes
Oct 4, 2019
🦋 Changeset is good to goLatest commit: 910b944 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 4, 2019
Closed
|
Just wondering if this update will make it into the next release. Also wondering when next release would be? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
props.isSearchableisfalse, aria attributes likearia-labelandaria-labelledbyare not passed through to theDummyInputcontrol that takes place of the input text box. Since the dummy component can't be replaced, making a non-searchable select breaks accessibility even though there are standards patterns for non-editable combo boxes.Since
react-selectconsumers have control over both the accessibility props andisSearchablewithout control overDummyInput, they should remove the accessibility props from the dummy input themselves by changing<Select>props.