Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noOptionsMessage #3676

Merged
merged 3 commits into from
Oct 2, 2019
Merged

noOptionsMessage #3676

merged 3 commits into from
Oct 2, 2019

Conversation

wiesys
Copy link
Contributor

@wiesys wiesys commented Jul 10, 2019

It should be noOptionsMessage, not noOptionsMessageCSS, because otherwise it throws Flow error:
Cannot create `Select` element because property `noOptionsMessage` is missing in `StylesConfig` [1] but exists in object literal [2] in property `styles`.

It should be `noOptionsMessage`, not `noOptionsMessageCSS`, because otherwise it throws Flow error:
```Cannot create `Select` element because property `noOptionsMessage` is missing in  `StylesConfig` [1] but exists in  object literal [2] in property `styles`.```
@VasiliKubarka
Copy link

@wiesys maybe you can change loadingMessageCSS?: StyleFn, to loadingMessage?: StyleFn, either?

Changed `loadingMessageCSS?: StyleFn`, to `loadingMessage?: StyleFn`.
@wiesys
Copy link
Contributor Author

wiesys commented Jul 19, 2019

Sure, no problem, @VasiliKubarka.

Copy link
Collaborator

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2019

🦋 Changeset is good to go

Latest commit: ae1c673

We got this.

Not sure what this means? Click here to learn what changesets are.

@emmatown emmatown merged commit cba1530 into JedWatson:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants