Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Flow lint rule implicit-inexact-object and fix issues #4320

Closed

Conversation

nifgraup
Copy link

@nifgraup nifgraup commented Dec 8, 2020

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2020

⚠️ No Changeset found

Latest commit: cb7c6ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb7c6ad:

Sandbox Source
react-codesandboxer-example Configuration

@nifgraup nifgraup force-pushed the flow-implicit-inexact-object branch 2 times, most recently from 1572922 to 541fdef Compare December 11, 2020 18:24
Remove duplicate config file .flowconfig-ci.
Allows dependant code to enable option exact_by_default.
@JedWatson
Copy link
Owner

Hey @nifgraup sorry but we've ended up with a lot of conflicts here, before the PR came up for review.

At first glance, I'd be happy to merge this (and thanks for picking it up!) but would you be up for resolving the conflicts?

Thanks 🙏

@Methuselah96
Copy link
Collaborator

@nifgraup It's worth noting that we are planning on transitioning away from Flow and to TypeScript in 5.0 (#4142). It's fine if you want to update this PR, just be warned that the changes will likely be overriden by TypeScript in the (relatively) near future.

@Methuselah96
Copy link
Collaborator

Thanks for the work on this, we've recently converted the code over to TypeScript (#4489) in preparation for v5 so the Flow types will no longer be relevant.

@nifgraup
Copy link
Author

Sounds like a good conclusion. New Flow libdefs can be derived from the TS code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants