-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Flow lint rule implicit-inexact-object and fix issues #4320
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb7c6ad:
|
1572922
to
541fdef
Compare
Remove duplicate config file .flowconfig-ci.
Allows dependant code to enable option exact_by_default.
541fdef
to
cb7c6ad
Compare
Hey @nifgraup sorry but we've ended up with a lot of conflicts here, before the PR came up for review. At first glance, I'd be happy to merge this (and thanks for picking it up!) but would you be up for resolving the conflicts? Thanks 🙏 |
Thanks for the work on this, we've recently converted the code over to TypeScript (#4489) in preparation for v5 so the Flow types will no longer be relevant. |
Sounds like a good conclusion. New Flow libdefs can be derived from the TS code. |
Allows dependant code to enable option exact_by_default.
https://medium.com/flow-type/on-the-roadmap-exact-objects-by-default-16b72933c5cf
https://medium.com/flow-type/how-to-upgrade-to-exact-by-default-object-type-syntax-7aa44b4d08ab