-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove browser alias fields #4423
Remove browser alias fields #4423
Conversation
🦋 Changeset detectedLatest commit: b8f9ec7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8f9ec7:
|
@mitchellhamilton do you know anything about this that would make this PR not the best way forward? |
There's nothing really wrong with merging this PR since in this case, the browser builds are pointless. react-select depends on emotion though and emotion has browser builds which have a non-trivial bundle size saving so this change won't really solve the problem for people. |
True. I've added a concluding comment to the linked issue. @JedWatson Up to you whether this is worth merging. The benefit of merging it would be that it would then definitely not be our problem and we could tell people to bug Emotion, their SSR library, and/or Webpack instead of bugging us. The browser builds for |
Resolves #3802.
The
browser
alias outputs aren't doing much anyway besides causing the bug in SSR (they just remove thetypeof window !== undefined
check in one place), so I think it practically makes sense to remove them even though we're technically doing everything correctly.