Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use combobox #4697

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Use combobox #4697

merged 6 commits into from
Jul 23, 2021

Conversation

MatthewCharlton
Copy link
Collaborator

@MatthewCharlton MatthewCharlton commented Jul 20, 2021

Add the role of combobox and the required ARIA attributes to the Input and DummyInput components to allow JAWS support and a better screen reader experience overall.

Linked to this proposal: #4695

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

🦋 Changeset detected

Latest commit: 3ef6e34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ef6e34:

Sandbox Source
react-codesandboxer-example Configuration

@MyvinB
Copy link

MyvinB commented Jul 22, 2021

Have tested the sandbox works well with Jaws hope this will merge soon will solve the aria problems with dropdown.

@JedWatson JedWatson enabled auto-merge July 22, 2021 23:26
Copy link
Collaborator

@seancurtis seancurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

auto-merge was automatically disabled July 22, 2021 23:46

Pull request was closed

@Methuselah96 Methuselah96 reopened this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants