remove remaining references to shared pointers

JeffersonLab · Aug 28, 2024 · 2e6d8d4 · 2e6d8d4
1 parent 56b74d7
commit 2e6d8d4
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/src/libsrc++/BaseStructure.cpp b/src/libsrc++/BaseStructure.cpp
@@ -170,7 +170,7 @@ namespace evio {
 
         if (dataType.isStructure()) {
             children.clear();
-            for (auto const & kid : structure->children) {
+            for (auto const kid : structure->children) {
                 children.push_back(kid);
             }
         }
@@ -1436,7 +1436,7 @@ namespace evio {
         }
 
         if (!(structure->isLeaf())) {
-            for (auto const & child : structure->getChildren()) {
+            for (auto const child : structure->getChildren()) {
                 visitAllDescendants(child, listener, filter);
             }
         }
@@ -2657,7 +2657,7 @@ namespace evio {
         else {
             datalen = 0;
 
-            for (auto const & child : children) {
+            for (auto const child : children) {
                 len = child->setAllHeaderLengths();
 //std::cout << "  setAllHeaderLengths: child len = " << len << "\n";
                 // Add this check to make sure structure is not being overfilled
@@ -2885,7 +2885,7 @@ namespace evio {
             }
         } // isLeaf
         else if (!children.empty()) {
-            for (auto const & child : children) {
+            for (auto const child : children) {
                 curPos += child->write(curPos, order);
             }
         } // not leaf
@@ -3376,7 +3376,7 @@ namespace evio {
             rawBytes.clear();
             // Get a rough idea of the size
             size_t sz = 0;
-            for (auto const & cd : compositeData) {
+            for (auto const cd : compositeData) {
                 size_t cdSz = cd->getRawBytes().size();
 //std::cout << "updateCompositeData: ADDing cd item of size = " << cdSz << "\n";
                 if (cdSz < 20) {

diff --git a/src/libsrc++/CompositeData.cpp b/src/libsrc++/CompositeData.cpp
@@ -437,7 +437,7 @@ namespace evio {
 
         // Get a total length (# bytes)
         size_t totalLen = 0, len;
-        for (auto const & cd : data) {
+        for (auto const cd : data) {
             len = cd->getRawBytes().size();
             totalLen += len;
         }
@@ -447,7 +447,7 @@ namespace evio {
 
         // Copy everything in
         int offset = 0;
-        for (auto const & cd : data) {
+        for (auto const cd : data) {
             len = cd->getRawBytes().size();
             if (cd->byteOrder != order) {
 //std::cout << "CompositeData::generateRawBytes call swapAll()" << std::endl;

diff --git a/src/libsrc++/EventParser.cpp b/src/libsrc++/EventParser.cpp
@@ -513,7 +513,7 @@ namespace  evio {
         }
 
         if (!(structure->isLeaf())) {
-            for (auto const & child : structure->children) {
+            for (auto const child : structure->children) {
                 visitAllDescendants(topLevelStruct, child, listener, filter);
             }
         }

diff --git a/src/libsrc++/EvioCompactReaderV4.cpp b/src/libsrc++/EvioCompactReaderV4.cpp
@@ -603,7 +603,7 @@ namespace evio {
 //" for tag/num = " << tag << "/" << num << std::endl;
 
         // Now look for matches in this event
-        for (auto const & enode: list) {
+        for (auto const enode: list) {
 //            std::cout << "searchEvent: desired tag = " << tag << " found " << enode->getTag() << std::endl;
 //            std::cout << "           : desired num = " << num << " found " << enode->getNum() << std::endl;
             if (enode->getTag() == tag && enode->getNum() == num) {
@@ -695,7 +695,7 @@ namespace evio {
         uint32_t removeNodePlace = 0;
 
         // Locate the node to be removed ...
-        for (auto const & ev : eventNodes) {
+        for (auto const ev : eventNodes) {
             removeNodePlace = 0;
 
             // See if it's an event ...
@@ -706,7 +706,7 @@ namespace evio {
                 break;
             }
 
-            for (auto const & n : ev->getAllNodes()) {
+            for (auto const n : ev->getAllNodes()) {
                 // The first node in allNodes is the event node,
                 // so do not increment removeNodePlace now.
 
@@ -747,8 +747,8 @@ namespace evio {
             byteBuffer = newBuffer;
 
             // All nodes need to use this new buffer
-            for (auto const & ev : eventNodes) {
-                for (auto const & n : ev->getAllNodes()) {
+            for (auto const ev : eventNodes) {
+                for (auto const n : ev->getAllNodes()) {
                     n->setBuffer(byteBuffer);
                 }
             }
@@ -988,7 +988,7 @@ namespace evio {
         uint32_t place = eventNode->place;
 
         for (int i=0; i < eventCount; i++) {
-            for (auto const & n : eventNodes[i]->getAllNodes()) {
+            for (auto const n : eventNodes[i]->getAllNodes()) {
                 // Make sure nodes are using the new buffer
                 n->setBuffer(newBuffer);
 

diff --git a/src/libsrc++/EvioCompactReaderV6.cpp b/src/libsrc++/EvioCompactReaderV6.cpp
@@ -208,7 +208,7 @@ namespace evio {
 //             " for tag/num = " << tag << "/" << +num << std::endl;
 
         // Now look for matches in this event
-        for (auto & enode: list) {
+        for (auto enode: list) {
 //std::cout << "searchEvent: desired tag = " << tag << " found " << enode->tag << std::endl;
 //std::cout << "           : desired num = " << +num << " found " << +(enode->num) << std::endl;
             if (enode->tag == tag && enode->num == num) {