Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix issue38 visualization PR into master #41

Merged
merged 4 commits into from
Oct 18, 2017
Merged

Hotfix issue38 visualization PR into master #41

merged 4 commits into from
Oct 18, 2017

Conversation

wdconinc
Copy link
Member

No description provided.

@wdconinc wdconinc mentioned this pull request Oct 17, 2017
Closed
cipriangal
cipriangal approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@cipriangal cipriangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Not really critical but would suggest formatting the readme file a bit better to make it clear that people need to set the env variable first and then run remoll (two different lines or put a semicolon between the two commands).

@wdconinc wdconinc merged commit 0e37474 into master Oct 18, 2017
@wdconinc wdconinc deleted the hotfix_issue38_visualization branch October 18, 2017 18:36
@rakithab rakithab mentioned this pull request Oct 10, 2018
Closed
This was referenced Apr 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipriangal cipriangal cipriangal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdconinc @cipriangal