improve error handling

Remove-AzAdApplication does not return boolean

Remove-AzAdApplications.ps1

@@ -6,7 +6,7 @@
 .DESCRIPTION
   Script to delete application registrations that are not tagged with 'persistent'. This script is intended to be run on a schedule to clean up unused application registrations. Tags are checked in the application manifest.
 .NOTES
-  Version:        1.0.0
+  Version:        1.0.1
   Author:         Jelle Broekhuijsen - jll.io Consultancy
   Creation Date:  11/8/2023
   
@@ -32,7 +32,7 @@ $applicationForRemoval = [System.Collections.Concurrent.ConcurrentBag[PSObject]]
 #Filter out applications that are not tagged with 'persistent'
 $applications | ForEach-Object -Parallel {
   $localApplicationForRemoval = $using:applicationForRemoval
-  $application = Get-AzADApplication -ObjectId $_.Id | Select-Object DisplayName,Id,AppId,Tag
+  $application = Get-AzADApplication -ObjectId $_.Id | Select-Object DisplayName, Id, AppId, Tag
   if ($application.Tag -notcontains 'persistent') {
     Write-Output "Marked application '$($application.DisplayName)' for removal"
     $localApplicationForRemoval.Add($application)
@@ -44,8 +44,10 @@ Write-Output "Found $($applicationForRemoval.Count) applications to remove"
 $applicationForRemoval | ForEach-Object -Parallel {
   $localFailures = $using:failures
   Write-Output "Removing application '$($_.DisplayName)'"
-  $result = Remove-AzADApplication -ObjectId $_.Id 
-  if ($result -ne $true) {
+  try {
+    Remove-AzADApplication -ObjectId $_.Id -ErrorAction Stop
+  }
+  catch {
     Write-Warning "Failed to remove application '$($_.DisplayName)'"
     $localFailures.Add($_)
   }