Add --check argument for CI
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to integrate `stubdefaulter` to `django-stubs`: typeddjango/django-stubs#2327 Later we also want to add `stubdefaulter` to our CI, so it can check that no missing defaults are added. `--check` would help us to fail the CI. We would use both `--exit-zero` and `--check`, because there would be errors when importing django modules, we can't fix it from our side. So, we need them both to work correctly. Errors will be ignored with `--exit-zero` while `--check` will return `2` if there are any new changes.
JelleZijlstra
approved these changes
Aug 7, 2024
|
This change has no effect on how stubdefaulter would alter typeshed's stdlib. 🤖🎉 |
|
The pyanalyze failures are unrelated, I think I need to cut a new pyanalyze release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to integrate
stubdefaultertodjango-stubs: typeddjango/django-stubs#2327Later we also want to add
stubdefaulterto our CI, so it can check that no missing defaults are added.--checkwould help us to fail the CI. We would use both--exit-zeroand--check, because there would be errors when importing django modules, we can't fix it from our side. So, we need them both to work correctly. Errors will be ignored with--exit-zerowhile--checkwill return2if there are any new changes.