Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJ-35134] bugfix: jira version 3.1.1 validates search_users params #338

Merged
merged 1 commit into from
May 8, 2024

Conversation

ametzger
Copy link
Member

@ametzger ametzger commented May 7, 2024

Fix exception:

 589   │ 2024-05-06 06:19:58,942 MainThread DEBUG jf_agent.jf_jira.jira_download Attempting wild card search with
 590   │ 2024-05-06 06:19:58,942 MainThread ERROR jf_ingest.logging_helper [3002] Failed to download jira data:
 591   │ Either 'user' or 'query' arguments must be specified.
 592   │ 2024-05-06 06:19:58,944 MainThread ERROR jf_ingest.logging_helper Traceback (most recent call last):
 593   │   File "/home/jf_agent/jf_agent/jf_jira/__init__.py", line 141, in load_and_dump_jira
 594   │     download_users(
 595   │   File "/python/pkgs/jf_ingest/diagnostics.py", line 66, in wrapper
 596   │     ret = func(*args, **kwargs)
 597   │   File "/python/pkgs/jf_ingest/logging_helper.py", line 28, in wrapper
 598   │     ret = func(*args, **kwargs)
 599   │   File "/home/jf_agent/jf_agent/jf_jira/jira_download.py", line 37, in download_users
 600   │     jira_users = _search_all_users(jira_connection, gdpr_active)
 601   │   File "/home/jf_agent/jf_agent/jf_jira/jira_download.py", line 866, in _search_all_users
 602   │     users = _search_users(
 603   │   File "/home/jf_agent/jf_agent/jf_jira/jira_download.py", line 950, in _search_users
 604   │     for u in retry_for_429s(
 605   │   File "/python/pkgs/jf_ingest/utils.py", line 137, in retry_for_429s
 606   │     return f(*args, **kwargs)
 607   │   File "/python/pkgs/jira/client.py", line 3187, in search_users
 608   │     raise ValueError("Either 'user' or 'query' arguments must be specified.")
 609   │ ValueError: Either 'user' or 'query' arguments must be specified.

@ametzger ametzger added the bug Something isn't working label May 7, 2024
@ametzger ametzger self-assigned this May 7, 2024
@ametzger ametzger requested a review from breid1313 May 8, 2024 18:27
Copy link
Contributor

@thingscouldbeworse thingscouldbeworse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more None either?

@ametzger
Copy link
Member Author

ametzger commented May 8, 2024

Yeah the library is now validating that the filters passed to it are truthy, so no more None or empty string

@ametzger ametzger merged commit 365c961 into master May 8, 2024
4 checks passed
@ametzger ametzger deleted the bug/oj-35134-filter-must-b-truthy branch May 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants