OJ-35758: rework log handlers to use a smart filter #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve how we divert/filter what logs go to the Console logger and what logs go to the Agent Log file.
Previously, we relied on exclusively filtering DEBUG level messages away from the Console logger, but into the Log file Handler. Now, we rely on the
send_to_agent_log_file
helper function fromjf_ingest.logging_helper
, which explicitly tags log records as being for only the agent log file. This allows us to retain the log records levels, instead of flattening them all tologging.DEBUG
This PR must be merged after this ingest PR is merged and deployed
Testing
Here is the Agent Console output, which is very user friendly. Below that is the log file, which contains some extra logging information (NOTE: the logs around "skipping sprints" are now INFO level logs instead of DEBUG :) )
jf_agent.log