Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about Error in no_std #382

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

JelteF
Copy link
Owner

@JelteF JelteF commented Jul 4, 2024

The error_in_core feature is not necessary anymore when building, because the feature got stabilized on nightly. Now it's just a waiting game until it is on actual stable Rust. This updates the documentation accordingly, as well as adding some no_std tests for Error.

@JelteF JelteF force-pushed the error-in-core-docs-update branch from 5617564 to 87fa2d5 Compare July 4, 2024 08:37
tyranron pushed a commit that referenced this pull request Jul 4, 2024
## Synopsis

While looking into #328 I realized the current situation around Pointer
derives
and references was even weirder because we store a double-reference to
the
fields in the local variables for Debug, but not for Display. The reason
we
were doing this was because of #289.


## Solution

This stops storing a double-reference, and only adds the additional
reference
in the places where its needed.
@JelteF JelteF added this to the 1.0.0 milestone Jul 4, 2024
@JelteF JelteF self-assigned this Jul 4, 2024
@JelteF JelteF merged commit c7a3111 into master Jul 5, 2024
17 checks passed
@JelteF JelteF deleted the error-in-core-docs-update branch July 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant