Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive AsRef and AsMut #88

Merged
merged 5 commits into from
Sep 15, 2019
Merged

Derive AsRef and AsMut #88

merged 5 commits into from
Sep 15, 2019

Conversation

reynoldsbd
Copy link
Contributor

Add derives for AsRef and AsMut traits, as discussed here.

@JelteF
Copy link
Owner

JelteF commented Sep 15, 2019

Thanks a lot for this PR!

@JelteF JelteF merged commit d7a03c9 into JelteF:master Sep 15, 2019
@reynoldsbd
Copy link
Contributor Author

@JelteF happy to contribute!

When can I expect these changes to be published to crates.io?

@JelteF
Copy link
Owner

JelteF commented Oct 5, 2019 via email

@reynoldsbd
Copy link
Contributor Author

No rush, just curious :)

Would you be willing to accept a similar PR for Borrow?

@JelteF
Copy link
Owner

JelteF commented Oct 5, 2019 via email

@JelteF
Copy link
Owner

JelteF commented Nov 3, 2019

@reynoldsbd are you still planning to send a PR for Borrow?

@reynoldsbd
Copy link
Contributor Author

@JelteF not at this time, turns out I didn't need it

@Boscop
Copy link

Boscop commented Jan 7, 2020

@JelteF @reynoldsbd I'm also interested in support for Borrow. Then there is no need to pull in shrinkwraprs, too.
(Reduced compile-time and less ways to do the same thing.)
And more fine-grained control instead of deriving all 3.

Btw, is DerefMut/AsMut already supported?

@JelteF
Copy link
Owner

JelteF commented Jan 7, 2020

@Boscop feel free to send in a PR for Borrow. And DerefMut and AsMut are supported indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants