-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive AsRef and AsMut #88
Conversation
Thanks a lot for this PR! |
@JelteF happy to contribute! When can I expect these changes to be published to crates.io? |
I expect end of this month, maybe next. I'm planning to make the next
release 0.99 (last before 1.0), which still requires some more work (mostly
cleanup and docs). If you're really in need of a release I can probably
create one earlier.
…On Sat, 5 Oct 2019, 03:49 Bobby Reynolds, ***@***.***> wrote:
@JelteF <https://github.com/JelteF> happy to contribute!
When can I expect these changes to be published to crates.io?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88?email_source=notifications&email_token=AAI3YJS3DJSTNJWP4W3AHBTQM7XAZA5CNFSM4IWZJ4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANHUPI#issuecomment-538606141>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI3YJVGR27HI75AJ7U3SWLQM7XAZANCNFSM4IWZJ4GQ>
.
|
No rush, just curious :) Would you be willing to accept a similar PR for Borrow? |
Yes, of course. I did change a lot of your original code quite a bit though
so I could use it for other derives too. So be sure to work from the latest
master.
…On Sat, 5 Oct 2019, 17:03 Bobby Reynolds, ***@***.***> wrote:
No rush, just curious :)
Would you be willing to accept a similar PR for Borrow?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88?email_source=notifications&email_token=AAI3YJSC7FDNUEQO2O67YXTQNCUERA5CNFSM4IWZJ4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANUGWA#issuecomment-538657624>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI3YJXWDG7QLXS2QXZYU5LQNCUERANCNFSM4IWZJ4GQ>
.
|
@reynoldsbd are you still planning to send a PR for Borrow? |
@JelteF not at this time, turns out I didn't need it |
@JelteF @reynoldsbd I'm also interested in support for Btw, is DerefMut/AsMut already supported? |
@Boscop feel free to send in a PR for |
Add derives for AsRef and AsMut traits, as discussed here.