Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use numbagg to calculate nanquantiles #20

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Use numbagg to calculate nanquantiles #20

merged 3 commits into from
Nov 24, 2023

Conversation

maawoo
Copy link
Member

@maawoo maawoo commented Nov 24, 2023

  • Renames sdc.utils.xclim_nanquantiles to sdc.utils.da_nanquantiles and replaces the usage of xclim.core.utils._nan_quantile with numbagg.nanquantiles (Relevant: Add nanquantile array function numbagg/numbagg#161)
  • Align sdc.utils.da_nanquantiles and sdc.utils.ds_nanquantiles with each other
  • Some minor improvements (typing, docstings, etc)

@maawoo maawoo added the enhancement New feature or request label Nov 24, 2023
@maawoo maawoo merged commit 6663e77 into main Nov 24, 2023
@maawoo maawoo deleted the feature/nanquantiles branch November 24, 2023 09:44
@maawoo maawoo mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maawoo