Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint story-custom-field.ts #277

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Lint story-custom-field.ts #277

merged 1 commit into from
Jun 4, 2024

Conversation

JensAstrup
Copy link
Owner

No description provided.

Copy link

github-actions bot commented Jun 4, 2024

This diff review shows changes made to a TypeScript file associated with custom fields management within a story-based application. The changes involve syntax and code style adjustments without altering the functionality. Here's a breakdown:

  1. Code Style Formatting:

    • The import statement for getHeaders has been adjusted to include spaces within the braces, aligning with best practices for readability and consistency in code style. This is shown in two instances:
      • import {getHeaders} from '@sx/utils/headers' changed to import { getHeaders } from '@sx/utils/headers'
      • Adding spaces when initializing CustomFieldsService with {headers: getHeaders()} changed to { headers: getHeaders() }
  2. Arrow Function Syntax:

    • Simplification of the arrow function inside the get name() method. Removing the parentheses around the parameter for a single parameter in an arrow function is an accepted practice that can make the code look cleaner and more concise.
      • return this.field.then((field) => field.name) changed to return this.field.then(field => field.name)

The changes adhere to common coding standards and improve the overall readability of the code. It's good to see attention to detail in areas such as code style and formatting, as these seemingly minor adjustments can greatly enhance code maintainability and consistency across a project. No functionality changes were introduced, and there aren't any corrections needed based on the information provided. Keep up the good work in ensuring that the code maintains high standards of clarity and cleanliness.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (6a94727) to head (9192a25).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
+ Coverage    91.20%   91.64%   +0.44%     
===========================================
  Files           50       50              
  Lines         2491     2491              
  Branches       167      167              
===========================================
+ Hits          2272     2283      +11     
+ Misses         219      208      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JensAstrup JensAstrup merged commit 3cff7e3 into develop Jun 4, 2024
11 checks passed
@JensAstrup JensAstrup deleted the lint_resolutions branch June 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant